Support flexible machine config for PowerVS - #83161
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughPowerVS worker resource variables are now configurable through the step reference. The command uses each configured value when present and reads the corresponding value from ChangesPowerVS worker resource configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
needs-ok-to-test
|
Hi @sonia-garudi. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| if [[ -z "${POWERVS_VSI_MEMORY}" ]]; then | ||
| POWERVS_VSI_MEMORY=$(jq -r '.powervsVSIMemory' "${AGENT_POWER_CREDENTIALS}/ibmcloud-resources.json") | ||
| fi | ||
| if [[ -z "${POWERVS_VSI_PROCESSORS}" ]]; then | ||
| POWERVS_VSI_PROCESSORS=$(jq -r '.powervsVSIProcessors' "${AGENT_POWER_CREDENTIALS}/ibmcloud-resources.json") | ||
| fi | ||
| if [[ -z "${POWERVS_VSI_PROC_TYPE}" ]]; then | ||
| POWERVS_VSI_PROC_TYPE=$(jq -r '.powervsVSIProcType' "${AGENT_POWER_CREDENTIALS}/ibmcloud-resources.json") | ||
| fi |
There was a problem hiding this comment.
You should just set the bash defaults ...
POWERVS_VSI_MEMORY=${POWERVS_VSI_MEMORY:-$(jq -r '.powervsVSIMemory' "$json_file")}
POWERVS_VSI_PROCESSORS=${POWERVS_VSI_PROCESSORS:-$(jq -r '.powervsVSIProcessors' "$json_file")}
POWERVS_VSI_PROC_TYPE=${POWERVS_VSI_PROC_TYPE:-$(jq -r '.powervsVSIProcType' "$json_file")}
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prb112, sonia-garudi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Sonia Garudi <sonia.garudi1@ibm.com>
a785808 to
8338c0b
Compare
|
New changes are detected. LGTM label has been removed. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-mce-e2e-power-ovn-conformance |
|
@sonia-garudi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@sonia-garudi: needs-ok-to-test label found, no rehearsals will be run |
|
/ok-to-test |
openshift-ci
Bot
added
ok-to-test
|
@sonia-garudi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Allow per-job override of POWERVS_VSI_MEMORY, POWERVS_VSI_PROCESSORS, and POWERVS_VSI_PROC_TYPE in the hypershift-mce-power-create-ibmcloud-workers-infra step for jobs with heavier workloads.
Summary by CodeRabbit
This change updates the OpenShift CI PowerVS worker infrastructure step for HyperShift MCE jobs.
ibmcloud-resources.json.